Build/Test Tools: Flag slow PHPUnit tests with annotations - #13212
Build/Test Tools: Flag slow PHPUnit tests with annotations#13212lancewillett wants to merge 3 commits into
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @lance.willett@a8c.com. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
There was a problem hiding this comment.
Pull request overview
This PR adds CI tooling to surface individual slow PHPUnit tests during GitHub Actions runs by parsing the generated JUnit report and emitting GitHub Actions warning annotations plus a step-summary Markdown table, targeting the canonical PHP 8.5 reporting job context.
Changes:
- Added a new PHP CLI script to parse
junit.xml, identify tests exceeding a configurable threshold, and emit warning annotations and a run summary. - Integrated a new “Flag slow PHPUnit tests” step into the reusable PHPUnit workflow (gated to PHP 8.5 + reporting-enabled runs on PRs and trunk pushes).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
tests/phpunit/prepare-slow-test-annotations.php |
New CLI parser that finds slow testcases in JUnit XML and outputs GitHub Actions annotations + a step summary table. |
.github/workflows/reusable-phpunit-tests-v3.yml |
Adds a workflow step that runs the new parser after the main PHPUnit run under the intended conditions. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
adimoldovan
left a comment
adimoldovan
left a comment
There was a problem hiding this comment.
One PHPCS error fails the build. The rest are small.
Two points that map to no line in the diff:
- #13083 adds class-wp-phpunit-timing-metrics.php, which streams the same junit.xml at the same point in the same workflow. Once it lands, this script should reuse it rather than walk the file a second time.
- The job's # Performs the following steps: list (lines 110-129) omits this step. #13083 updates that list for its own step.
Parse the JUnit report from the canonical PHP 8.5 report job and emit GitHub Actions warning annotations plus a run-summary table for tests over a threshold, on pull requests and pushes to trunk. Advisory only: the step runs even on failed test runs and never fails the build itself. This names the slow tests, complementing the aggregate CodeVitals trend that stores them without naming any one test. See #65887.
ac5472e to
da3eb42
Compare
The canonical PHP 8.5 reporting job now emits warning annotations and a run-summary table for tests that exceed one second. The advisory step runs after successful or failed test runs and skips cancelled jobs. The annotation pass reuses the streaming JUnit parser introduced in [63410] and passes its six aggregate metrics to CodeVitals through a temporary file. This keeps the workflow to one traversal of the report. Developed in: #13212 Props adrianmoldovanwp. See #65887. git-svn-id: https://develop.svn.wordpress.org/trunk@63412 602fd350-edb4-49c9-b593-d223f7449a82
The canonical PHP 8.5 reporting job now emits warning annotations and a run-summary table for tests that exceed one second. The advisory step runs after successful or failed test runs and skips cancelled jobs. The annotation pass reuses the streaming JUnit parser introduced in [63410] and passes its six aggregate metrics to CodeVitals through a temporary file. This keeps the workflow to one traversal of the report. Developed in: WordPress/wordpress-develop#13212 Props adrianmoldovanwp. See #65887. Built from https://develop.svn.wordpress.org/trunk@63412 git-svn-id: http://core.svn.wordpress.org/trunk@62605 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
Commit landed in https://core.trac.wordpress.org/changeset/63412 |
Trac ticket: https://core.trac.wordpress.org/ticket/65887
What this changes
Adds a
Flag slow PHPUnit testsstep to the canonical PHP 8.5 report job. It parses the JUnit report and, for tests over a threshold (default 1s), emits GitHub Actions warning annotations and a run-summary table naming the slowest tests. Runs on pull requests and pushes to trunk.This complements #13083: those six CodeVitals aggregates store the trend but cannot name a test. This one names the slow ones, so a PR author can spot a slow test they added.
The annotation pass reuses #13083's streaming parser and passes its six aggregate metrics to the CodeVitals publisher through the runner's temporary directory. On trunk, both features now traverse the JUnit report once.
Behavior
!cancelled()), and never fails the job (continue-on-error).Use of AI Tools
AI assistance: Yes
Tool(s): Codex (via Claude Code), hardened with an adversarial multi-lens review
Used for: drafting the workflow step and PHP script, and reviewing it before submission.